feat: let scoped app passwords read notifications and register for push

.github/workflows/performance.yml

@@ -90,7 +90,7 @@ jobs:
           persist-credentials: false
           submodules: true
           repository: nextcloud/server
-          ref: ${{ matrix.server-versions }}
+          ref: feat/noid/app-password-route-gate
 
       - name: Checkout app
         uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

lib/Controller/EndpointController.php

@@ -10,11 +10,13 @@
 
 namespace OCA\Notifications\Controller;
 
+use NCU\AppFramework\Http\Attribute\TokenScope;
 use OCA\Notifications\Exceptions\NotificationNotFoundException;
 use OCA\Notifications\Handler;
 use OCA\Notifications\Push;
 use OCA\Notifications\ResponseDefinitions;
 use OCA\Notifications\Service\ClientService;
+use OCA\Notifications\TokenScopes;
 use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\Attribute\ApiRoute;
 use OCP\AppFramework\Http\Attribute\NoAdminRequired;
@@ -38,6 +40,7 @@
  * @psalm-import-type NotificationsNotification from ResponseDefinitions
  * @psalm-import-type NotificationsNotificationAction from ResponseDefinitions
  */
+#[TokenScope(scope: TokenScopes::NOTIFICATIONS_READ)]
 class EndpointController extends OCSController {
 	public function __construct(
 		string $appName,

lib/Controller/PushController.php

@@ -9,9 +9,11 @@
 
 namespace OCA\Notifications\Controller;
 
+use NCU\AppFramework\Http\Attribute\TokenScope;
 use OC\Authentication\Token\IProvider;
 use OC\Security\IdentityProof\Manager;
 use OCA\Notifications\ResponseDefinitions;
+use OCA\Notifications\TokenScopes;
 use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\Attribute\ApiRoute;
 use OCP\AppFramework\Http\Attribute\NoAdminRequired;
@@ -32,6 +34,7 @@
  * @psalm-import-type NotificationsPushDevice from ResponseDefinitions
  */
 #[OpenAPI(scope: 'push')]
+#[TokenScope(scope: TokenScopes::NOTIFICATIONS_READ)]
 class PushController extends OCSController {
 	public function __construct(
 		string $appName,

lib/Controller/SettingsController.php

@@ -9,9 +9,11 @@
 
 namespace OCA\Notifications\Controller;
 
+use NCU\AppFramework\Http\Attribute\TokenScope;
 use OCA\Notifications\AppInfo\Application;
 use OCA\Notifications\Model\Settings;
 use OCA\Notifications\Model\SettingsMapper;
+use OCA\Notifications\TokenScopes;
 use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\Attribute\ApiRoute;
 use OCP\AppFramework\Http\Attribute\NoAdminRequired;
@@ -48,6 +50,7 @@
 	#[NoAdminRequired]
 	#[OpenAPI]
 	#[ApiRoute(verb: 'POST', url: '/api/{apiVersion}/settings', requirements: ['apiVersion' => '(v2)'])]
+	#[TokenScope(scope: TokenScopes::NOTIFICATIONS_READ)]
 	public function personal(int $batchSetting, string $soundNotification, string $soundTalk): DataResponse {
 		$this->settingsMapper->setBatchSettingForUser($this->settingsMapper->getSettingsByUser($this->userId), $batchSetting);
 

lib/Controller/WebPushController.php

@@ -9,8 +9,10 @@
 
 namespace OCA\Notifications\Controller;
 
+use NCU\AppFramework\Http\Attribute\TokenScope;
 use OC\Authentication\Token\IProvider;
 use OC\Security\IdentityProof\Manager;
+use OCA\Notifications\TokenScopes;
 use OCA\Notifications\WebPush\ActivationSubStatus;
 use OCA\Notifications\WebPush\NewSubStatus;
 use OCA\Notifications\WebPushClient;
@@ -35,6 +37,7 @@
 use Symfony\Component\Uid\Uuid;
 
 #[OpenAPI(scope: 'webpush')]
+#[TokenScope(scope: TokenScopes::NOTIFICATIONS_READ)]
 class WebPushController extends OCSController {
 	public function __construct(
 		string $appName,

lib/TokenScopes.php

@@ -0,0 +1,17 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+namespace OCA\Notifications;
+
+/**
+ * App password scopes for notifications
+ */
+class TokenScopes {
+	public const NOTIFICATIONS_READ = 'notifications:notifications:read';
+}

tests/Unit/Controller/TokenScopeTest.php

@@ -0,0 +1,58 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+namespace OCA\Notifications\Tests\Unit\Controller;
+
+use NCU\AppFramework\Http\Attribute\TokenScope;
+use OCA\Notifications\Controller\APIController;
+use OCA\Notifications\Controller\EndpointController;
+use OCA\Notifications\Controller\PushController;
+use OCA\Notifications\Controller\SettingsController;
+use OCA\Notifications\Controller\WebPushController;
+use OCA\Notifications\TokenScopes;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Test\TestCase;
+
+class TokenScopeTest extends TestCase {
+	public static function openControllers(): array {
+		return [
+			'notifications' => [EndpointController::class],
+			'push registration' => [PushController::class],
+			'web push registration' => [WebPushController::class],
+		];
+	}
+
+	#[DataProvider('openControllers')]
+	public function testOpenControllers(string $class): void {
+		$attribute = (new \ReflectionClass($class))->getAttributes(TokenScope::class)[0];
+		$this->assertSame(TokenScopes::NOTIFICATIONS_READ, $attribute->getArguments()['scope']);
+	}
+
+	public function testPersonalSettingsOnly(): void {
+		$personal = (new \ReflectionMethod(SettingsController::class, 'personal'))->getAttributes(TokenScope::class)[0];
+		$this->assertSame(TokenScopes::NOTIFICATIONS_READ, $personal->getArguments()['scope']);
+		$this->assertSame([], (new \ReflectionMethod(SettingsController::class, 'admin'))->getAttributes(TokenScope::class));
+		$this->assertSame([], (new \ReflectionClass(SettingsController::class))->getAttributes(TokenScope::class));
+	}
+
+	public static function closedControllers(): array {
+		return [
+			'admin' => [APIController::class],
+		];
+	}
+
+	#[DataProvider('closedControllers')]
+	public function testClosedControllers(string $class): void {
+		$class = new \ReflectionClass($class);
+		$this->assertSame([], $class->getAttributes(TokenScope::class));
+		foreach ($class->getMethods(\ReflectionMethod::IS_PUBLIC) as $method) {
+			$this->assertSame([], $method->getAttributes(TokenScope::class), $method->getName());
+		}
+	}
+}