Repository navigation
docs: HaRP checks the route verb - #19
Merged
Merged
Conversation
Signed-off-by: Oleksandr Piskun <oleksandr2088@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guides say HaRP matches routes by
urlonly and ignoresverb, and that the PHP proxy refuses a request with404. Since nextcloud/HaRP#149 HaRP takes the first route whoseurlandverbboth match, acceptsHEADwhereGETis listed and answers a method no route of the path lists with405. nextcloud/app_api#1144 made the PHP proxy acceptHEADonGETroutes too, and nextcloud/app_api#1149 raises the HaRP version AppAPI requires to0.4.8.Changes
exapp-contract.md: how HaRP 0.4.8+ and the PHP proxy pick a route byurlandverb, when a refused request gets404and when405, that HaRP'surlregex is case-sensitive, and to list every method a route serves in itsverb.harp-operations.mdandSKILL.md:405in the status tables and in troubleshooting, and the0.4.8minimum from fix(harp): require HaRP 0.4.8 in the version check app_api#1149 with its one-hour cache.