[saw-jan]

Description

Current this.$emit('submit', link) in SearchInput component no longer triggers a native DOM event in Vue3 as it is treated as the component event, but the vue3 version of @nextcloud/vue expects the native events, See https://github.com/nextcloud-libraries/nextcloud-vue/blob/390653107207ae3cfa100d29330861a5fc3a3d60/src/components/NcRichText/NcReferencePicker/NcCustomPickerElement.vue#L69-L70

				this.renderResult.element.addEventListener('submit', (e) => {
					this.onSubmit(e.detail)
				})

Due to this very reason, the submit event was not caught and the wp link didn't get copied to the textbox. To fix this, we emit a native event.

Related Issue or Workpackage

• Fixes https://community.openproject.org/wp/NEX-724

Screenshots (if appropriate):

After fix:

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Updated CHANGELOG.md file

[github-actions]

JS Code Coverage

Coverage after merging fix/smart-picker-wp-selection into master will be

83.08%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
adminSettings.js	0%	100%	100%	0%	12–14
dashboard.js	0%	100%	0%	0%	10–12, 15–16
personalSettings.js	0%	100%	100%	0%	12–14
projectTab.js	0%	0%	0%	0%	16–17, 20, 24, 30, 34, 34, 34, 36, 38
reference.js	0%	100%	0%	0%	14, 16, 18, 22, 24–25, 27, 32–34, 36–37, 42–44, 46–48, 50, 52
setup.js	0%	100%	0%	0%	10–13, 9
src/components
AdminSettings.vue	87.22%	81.58%	93.55%	87.50%	206, 227, 227, 227–228, 24, 247–248, 272–273, 273, 273–274, 276, 78
ErrorLabel.vue	50%	100%	100%	50%	6
OAuthConnectButton.vue	80.77%	68.75%	100%	81.48%	63–64, 66–67, 69, 72, 72, 72–73, 75
PersonalSettings.vue	79.81%	80.43%	85%	76.32%	132–133, 143–145, 145, 145, 145, 145–146, 151–152, 152, 152, 154, 154, 157, 18
src/components/admin
FieldValue.vue	100%	100%	100%	100%
FormAuthMethod.vue	87.97%	86.11%	87.10%	89.39%	221, 224, 248, 248, 248–250, 32, 40, 82, 82, 82
FormHeading.vue	75%	70%	100%	100%	12, 15, 9
FormOAuthSettings.vue	87.76%	91.04%	81.82%	88.24%	101, 137, 217, 248, 351, 351, 351–352, 375, 375, 375–376, 61, 61, 61, 85
FormOpenProjectHost.vue	95.52%	90.91%	95.45%	97.47%	156, 159, 53, 53, 53
FormProjectFolder.vue	89.64%	87.50%	90%	91.14%	100, 100, 100–101, 101, 119, 139, 269, 322, 341, 341–342, 376, 376–377, 389–390, 408, 410, 431–433, 460, 462, 490, 490, 490–491, 69
FormSSOSettings.vue	93.44%	94.29%	90.48%	93.75%	123, 139, 139, 139, 232–233, 238, 244, 294, 359–360, 384, 74
TermsOfServiceUnsigned.vue	100%	100%	100%	100%
TextInput.vue	79.49%	100%	60%	75.76%	147, 152, 23–27, 47
src/components/icons
ClippyIcon.vue	66.67%	100%	0%	66.67%	11
OpenProjectIcon.vue	66.67%	100%	0%	66.67%	11
src/components/settings
CheckBox.vue	81.82%	100%	60%	71.43%	15–16
ErrorNote.vue	100%	100%	100%	100%
SettingsTitle.vue	91.30%	75%	100%	93.33%	48, 51
src/components/tab
EmptyContent.vue	92%	88.37%	100%	96.15%	10, 106–107, 12, 12, 16
SearchInput.vue	88.41%	85.90%	91.18%	89.26%	172, 179, 18, 180, 180, 180–181, 198, 209–210, 210, 210–211, 213, 251, 283, 286, 289, 300–302, 306, 309–310
WorkPackage.vue	84.12%	73.58%	83.33%	89.90%	118–120, 151–154, 165–166, 228–229, 233, 233, 233, 233–236, 7, 7, 7, 7, 90–91
src/filesPlugin
filesPlugin.js	0%	0%	0%	0%	100, 104–106, 108, 111, 113, 115–117, 119–120, 122, 126–127, 15, 15, 15, 19, 27–29, 32, 34–36, 40, 42, 46, 48, 52, 52, 52, 52, 54, 56, 59–61, 63, 63, 63–65, 68–69, 71–72, 76, 80, 82, 86, 86, 86, 86, 88, 90, 93–95
src/utils
workpackageHelper.js	92.56%	94.87%	88.89%	91.78%	102–104, 106, 27, 57, 57–58
src/views
CreateWorkPackageModal.vue	87.10%	81.48%	86.36%	89.83%	110, 137, 153, 371–372, 374–375, 379, 395, 512, 512, 512–513, 515, 520–521, 523–524, 53, 530–531, 533–534, 541, 541, 541–542, 544, 547, 557, 588, 597, 604–605, 605, 605–606, 619, 641, 644, 653, 684, 692, 700, 705, 707, 707, 707–708, 719–721, 79, 92, 95
Dashboard.vue	83.59%	80.60%	80%	86.73%	118, 118, 118–119, 121, 132, 142, 145, 15, 15, 15, 15, 15, 157, 16, 16, 16, 168, 17, 213–214, 218–220, 228–229
LinkMultipleFilesModal.vue	98.36%	97.30%	100%	98.48%	156–157
ProjectsTab.vue	86.11%	83.93%	83.33%	88.30%	103–105, 118, 142, 153–154, 189, 189, 189–192, 194, 197, 224, 248–249, 259, 269
WorkPackagePickerElement.vue	0%	0%	0%	0%	100–101, 101, 101, 101, 101–102, 104, 14, 14, 14, 17–18, 18, 39, 48, 57, 6, 60, 63, 63, 63, 63, 63–64, 66, 66, 66, 66, 66–67, 69, 7, 73, 77, 80, 80, 80–82, 84–86, 88–89, 89, 89–92, 95, 98–99, 99, 99, 99, 99, 99
WorkPackageReferenceWidget.vue	0%	0%	0%	0%	18, 33, 58, 66, 7, 71,

[Ashim-Stha]

Suggested change

	- Selecting an OpenProject work package does not insert the reference [#1200](https://github.com/nextcloud/integration_openproject/pull/1200)
	- Selecting an OpenProject work package does not insert the reference in smart picker [#1200](https://github.com/nextcloud/integration_openproject/pull/1200)