Skip to content

test(api): remove expected failure tag from passing test - #1196

Merged
saw-jan merged 1 commit into
masterfrom
test/passing-test
Oct 26, 2026
Merged

test(api): remove expected failure tag from passing test#1196
saw-jan merged 1 commit into
masterfrom
test/passing-test

Conversation

@saw-jan

@saw-jan saw-jan commented Oct 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

upload with exact quota size test scenario began to pass.

Currently, the fix is merged only in master and stable34 branches

Related Issue or Workpackage

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Updated CHANGELOG.md file

@saw-jan saw-jan self-assigned this Oct 26, 2026
@saw-jan
test(api): remove expected failure tag from passing test
da25c56 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
@github-actions

github-actions Bot commented Oct 26, 2026

Copy link
Copy Markdown

PHP Code Coverage

Coverage after merging test/passing-test into master will be
69.56%
Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
integration_openproject/server/apps/integration_openproject/lib
   Capabilities.php0%100%0%0%24, 31–40
   OIDCClientMapper.php0%100%0%0%29, 40–49, 52
   ServerVersion.php0%100%0%0%17, 27–29, 32, 41–42
   TokenEventFactory.php100%100%100%100%
integration_openproject/server/apps/integration_openproject/lib/AppInfo
   Application.php37.04%100%50%36%116–118, 121–135, 138, 140, 142–143, 146, 151–152, 156–159, 161–172, 174, 177, 181, 185–187, 220
integration_openproject/server/apps/integration_openproject/lib/BackgroundJob
   RemoveExpiredDirectUploadTokens.php0%100%0%0%28, 30–32, 41–42
integration_openproject/server/apps/integration_openproject/lib/Controller
   ConfigController.php77.98%100%70.59%78.32%106, 143–144, 146, 148–150, 152–155, 158–159, 161, 186, 190–192, 377–379, 381–383, 432, 512–516, 527, 541–544, 552, 556–559, 601–616, 657, 660–675, 689–695
   DirectDownloadController.php0%100%0%0%33–35, 50–52, 54–61
   DirectUploadController.php71.03%100%100%70.21%117–119, 162–164, 175, 179–182, 184, 194, 201, 217–219, 221–222, 225–230, 233, 235, 245–247, 253–255, 263–265, 280–282, 301, 306, 312
   FilesController.php85.83%100%83.33%85.95%181–182, 246, 255, 272–275, 280–282, 287–289, 301, 303, 306
   OpenProjectAPIController.php81.09%100%82.35%80.98%116, 155, 202–204, 207–214, 216–220, 222, 241, 266, 331, 381, 401, 448, 473–475, 478–482, 484, 66
   OpenProjectController.php96.45%100%80%96.95%241–245
integration_openproject/server/apps/integration_openproject/lib/Dashboard
   OpenProjectWidget.php0%100%0%0%101, 108–109, 111–116, 118–122, 124–126, 129–140, 61–66, 73, 80, 87, 94
integration_openproject/server/apps/integration_openproject/lib/Exception
   OpenprojectAvatarErrorException.php100%100%100%100%
   OpenprojectErrorException.php100%100%100%100%
   OpenprojectFileNotUploadedException.php100%100%100%100%
   OpenprojectGroupfolderSetupConflictException.php100%100%100%100%
   OpenprojectResponseException.php100%100%100%100%
   OpenprojectUnauthorizedUserException.php0%100%0%0%21
integration_openproject/server/apps/integration_openproject/lib/Listener
   BeforeGroupDeletedListener.php100%100%100%100%
   BeforeNodeInsideOpenProjectGroupfilderChangedListener.php0%100%0%0%46–48, 52–55, 57, 59, 62–63, 65, 67–70, 72–75, 77–79
   BeforeUserDeletedListener.php40%100%50%37.50%30, 38, 42–43, 45
   LoadAdditionalScriptsListener.php0%100%0%0%37–38, 46–47, 49, 51–52, 54
   LoadSidebarScript.php65.91%100%100%64.29%105, 77–88, 95, 98
   OpenProjectReferenceListener.php0%100%0%0%45–47, 54–55, 57, 59–60, 62–74
   TermsOfServiceEventListener.php0%100%0%0%41–42, 47–48, 50–51, 53–55, 58–62
   UserChangedListener.php0%100%0%0%34, 41–42, 45–50, 53
   UserLoggedInEventListener.php0%100%0%0%27, 35–36, 39, 42
integration_openproject/server/apps/integration_openproject/lib/Migration
   Version2001Date20221213083550.php0%100%0%0%30, 41–43, 46–54, 56–64, 66–68, 70
   Version20100Date20250820101358.php0%100%0%0%38, 47–53, 56
   Version2310Date20230116153411.php0%100%0%0%29, 32–35, 37–62, 64–65, 67
   Version2400Date20230504144300.php0%100%0%0%30, 41–44, 46
   Version2640Date20240628114301.php0%100%0%0%35, 47–49, 52–53, 56
   Version2900Date20250718065820.php0%100%0%0%22, 33–36, 38–39, 41–42, 45
integration_openproject/server/apps/integration_openproject/lib/Reference
   WorkPackageReferenceProvider.php51.67%100%25%58.33%100–101, 104, 108, 142, 150–151, 159, 37, 44, 51, 58–60, 87, 93–96, 99
integration_openproject/server/apps/integration_openproject/lib/Search
   OpenProjectSearchProvider.php0%100%0%0%100–102, 104–106, 109–110, 112–113, 116–125, 127–131, 52–55, 62, 69, 77, 79, 82, 89–90, 93–97, 99
   OpenProjectSearchResultEntry.php100%100%100%100%
integration_openproject/server/apps/integration_openproject/lib/Service
   DatabaseService.php42.31%100%60%40.43%108–112, 114, 63–76, 78–85
   DirectDownloadService.php100%100%100%100%
   DirectUploadService.php42.86%100%66.67%40%101, 62–65, 67–75, 95
   OauthService.php96.15%100%100%95.65%124, 144
   OpenProjectAPIService.php78.41%100%80%78.29%1005–1006, 1008, 1010–1011,

@saw-jan
saw-jan marked this pull request as ready for review October 26, 2026 08:18
@saw-jan
saw-jan merged commit 4df884d into master Oct 26, 2026
10 checks passed
@saw-jan
saw-jan deleted the test/passing-test branch October 26, 2026 08:36
@saw-jan

saw-jan commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to release/3.2

@saw-jan

saw-jan commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to release/3.3

@backportbot

backportbot Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

The backport to release/3.2 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout release/3.2
git pull origin release/3.2

# Create the new backport branch
git checkout -b backport/1196/release/3.2

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick da25c560

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1196/release/3.2

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot

backportbot Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

The backport to release/3.3 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout release/3.3
git pull origin release/3.3

# Create the new backport branch
git checkout -b backport/1196/release/3.3

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick da25c560

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1196/release/3.3

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@saw-jan

saw-jan commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator Author

/backport 4df884d to release/3.2

@backportbot

backportbot Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

The backport to release/3.2 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout release/3.2
git pull origin release/3.2

# Create the new backport branch
git checkout -b backport/1196/release/3.2

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 4df884d8

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1196/release/3.2

Error: Failed to check for changes with origin/release/3.2: No changes found in backport branch

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@saw-jan

saw-jan commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator Author

/backport 4df884d to release/3.3

@backportbot backportbot Bot mentioned this pull request Oct 26, 2026
Open
@saw-jan saw-jan mentioned this pull request Oct 26, 2026
Draft
saw-jan added a commit that referenced this pull request Oct 26, 2026
@saw-jan
test(api): remove expected failure tag from passing test (#1196)
a643fbd 
Signed-off-by: Saw-jan <saw.jan.grg3e@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ashim-Stha Ashim-Stha Ashim-Stha approved these changes
@julien-nc julien-nc Awaiting requested review from julien-nc julien-nc is a code owner
@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner
@ba1ash ba1ash Awaiting requested review from ba1ash ba1ash is a code owner
@dominic-braeunlein dominic-braeunlein Awaiting requested review from dominic-braeunlein dominic-braeunlein is a code owner
@Kharonus Kharonus Awaiting requested review from Kharonus Kharonus is a code owner
@psatyal psatyal Awaiting requested review from psatyal psatyal is a code owner
@wielinde wielinde Awaiting requested review from wielinde wielinde is a code owner
@NobodysNightmare NobodysNightmare Awaiting requested review from NobodysNightmare NobodysNightmare is a code owner
@shiroginne shiroginne Awaiting requested review from shiroginne shiroginne is a code owner

Assignees

@saw-jan saw-jan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saw-jan @Ashim-Stha