Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Author
|
@codex review |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Add an admin setting with a list of email domains for which no guest accounts can be created. An entry blocks the domain and all of its subdomains, but not unrelated domains sharing the same suffix. The check is enforced in the guest creation API and in occ guests:add. Entries are normalised (lower-case, leading "@", "*." and dots removed) and invalid entries are dropped. Internationalized domains are compared in their punycode form, so "bücher.de" also blocks "xn--bcher-kva.de" and upper-case variants. Existing guests are not affected. Closes nextcloud#925 Assisted-by: ClaudeCode:claude-opus-5-5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TDY7TLSfZ2zVWLDsTsnqrF Signed-off-by: Johannes B. Hartmann <mail@jbhs.de>
jbhs
force-pushed
the
feat/block-guest-email-domains
branch
from
October 20, 2026 21:02
e936873 to
d660dfb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI (if applicable)
The implementation, testing, and security review were carried out with the support of Claude (Claude Code). I reviewed the changes, ran lint/build and unit tests, and manually tested the feature on Nextcloud 34, 35 and 36.
Description
This feature adds a field in the admin area that allows you to exclude specific email domains and their subdomains from creating guest accounts. This is useful, for example, to prevent guest accounts from being created for email addresses that are intended to register as full accounts or that are intended to use the Federated Share feature.
The restriction applies in the guest creation API (i.e., in the share dialog). An error message is displayed in this case. For the command
occ guests:add.The ability for an admin to convert an existing account into a guest account has been intentionally left enabled.
User Interface
Admin
User
Closes #925