Repository navigation
fix: embed inline logo in guest invitation emails - #1719
Conversation
Use IMessage::useTemplate() so inline images from EMailTemplate (the cid:logo theming logo since Nextcloud 34) are attached. Signed-off-by:Klaus Salminen klaus@andqfive.com Signed-off-by: klaussalminenq5 <klaus@andqfive.com>
Signed-off-by: klaussalminenq5 <klaus@andqfive.com>
|
Applied this patch on a Nextcloud 34.0.4 instance with Guests 4.10.0. Invitation emails now show the inline logo and the correct subject. |
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Thanks! Confirmed: the logo became an inline cid:logo attachment in server 34, and only useTemplate() attaches it.
Small nit, not blocking: the setSubject($subject) before useTemplate() is now dead, since useTemplate() overwrites it. You could set it on the template instead ($emailTemplate->setSubject($subject)) and drop both message calls.
useTemplate() overwrites the message subject with the template one. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvo忙 <14975046+skjnldsv@users.noreply.github.com>
|
Just did it 馃き馃き |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Since Nextcloud 34, EMailTemplate embeds the theming logo inline
(src="cid:logo"). The image is only attached in Message::useTemplate().
The guest invitation called setHtmlBody()/setPlainBody() directly, so
the HTML referenced cid:logo but no image part was attached, and
recipients saw a broken logo.
This switches to useTemplate() and sets the subject afterward, since
useTemplate() overwrites it with the template subject.
Tested: core "Send test email" shows the logo on the same instance;
guest invitations show a broken image without this change.
Fixes #1718