Repository navigation
fix(settings): Load guest details by user id instead of email - #1670
Conversation
The guest list passed the email address to GuestDetails, which requests
/apps/guests/api/v1/users/{userId}. That endpoint resolves shares by
user id, and hashing the email into the user id is the default, so
expanding a row showed an empty share list even though the "Received
shares" column of the very same row reported shares.
Verified against a guest with one incoming share: getGuestInfo() returns
one share for the user id and none for the email address.
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
cd33460 to
fd4e123
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
The guest list passed the email address to GuestDetails, which requests /apps/guests/api/v1/users/{userId}. That endpoint resolves shares by user id, and hashing the email into the user id is the default, so expanding a row showed an empty share list even though the "Received shares" column of the very same row reported shares.