Skip to content

fix(notifications): Use the target id in guest conversion notifications - #1669

Merged
CarlSchwan merged 1 commit into
nextcloud:mainfrom
solracsf:fix/transfer-notification-target-id
Aug 21, 2026
Merged

CarlSchwan merged 1 commit into
nextcloud:mainfrom
solracsf:fix/transfer-notification-target-id

Conversation

@solracsf

Copy link
Copy Markdown
Member

The rich object describing the converted-to account fell back to the guest id when the target account could not be resolved, so a failed conversion reported the guest twice instead of naming the account it was supposed to become.

@solracsf solracsf added bug Something isn't working 3. to review Waiting for reviews labels Aug 16, 2026
The rich object describing the converted-to account fell back to the
guest id when the target account could not be resolved, so a failed
conversion reported the guest twice instead of naming the account it was
supposed to become.

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@CarlSchwan
CarlSchwan force-pushed the fix/transfer-notification-target-id branch from a5ea525 to 00b52d8 Compare August 21, 2026 08:34
@CarlSchwan
CarlSchwan enabled auto-merge August 21, 2026 08:34
@CarlSchwan
CarlSchwan merged commit b671349 into nextcloud:main Aug 21, 2026
55 checks passed
@solracsf
solracsf deleted the fix/transfer-notification-target-id branch August 21, 2026 09:13
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants