Repository navigation
fix(backend): Keep the display name ordering when searching guests - #1668
Conversation
orderBy() replaces the order-by clause instead of appending to it, so the second call dropped the display name ordering and left the results sorted by user id only. With hashed user ids that ordering is effectively random, and it also decides which guests a limited search returns. Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
7cfe3e4 to
da5c7c9
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
orderBy() replaces the order-by clause instead of appending to it, so the second call dropped the display name ordering and left the results sorted by user id only. With hashed user ids that ordering is effectively random, and it also decides which guests a limited search returns.