Repository navigation
fix(backend): Upgrade outdated password hashes on email logins - #1667
Conversation
checkPassword() accepts the user id or the email address, but handed the login name straight to setPassword(), which matches on uid_lower. When a guest with a hashed user id logged in with their email address the update therefore matched no row and the outdated hash stayed in place, so it was re-computed and dropped on every single login. Use the user id that the lookup already returned. Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
62f1329 to
7d26801
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
checkPassword() accepts the user id or the email address, but handed the login name straight to setPassword(), which matches on uid_lower. When a guest with a hashed user id logged in with their email address the update therefore matched no row and the outdated hash stayed in place, so it was re-computed and dropped on every single login.
Use the user id that the lookup already returned.