Repository navigation
fix(whitelisting): Never treat the empty app id as whitelisted - #1666
Conversation
WHITELIST_ALWAYS started with a comma, so exploding it produced an empty
first entry and isAppWhitelisted('') returned true. getRequestedApp()
returns an empty string whenever IAppManager::cleanAppId() strips the
path segment down to nothing, which made those requests pass the
allowlist check.
Config::getAppWhitelist() had the same problem: exploding an empty
setting yields a single empty entry, which was both whitelisted and
rendered as a blank chip in the admin settings.
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
a90f12b to
0c2856a
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
WHITELIST_ALWAYS started with a comma, so exploding it produced an empty first entry and isAppWhitelisted('') returned true. getRequestedApp() returns an empty string whenever IAppManager::cleanAppId() strips the path segment down to nothing, which made those requests pass the allowlist check.
Config::getAppWhitelist() had the same problem: exploding an empty setting yields a single empty entry, which was both whitelisted and rendered as a blank chip in the admin settings.