Repository navigation
fix(whitelisting): Make the blocked app message translatable again - #1665
Conversation
The app id was interpolated into the string handed to IL10N::t(), so the lookup key differed for every blocked app and matched no entry in any catalogue. The message was therefore always shown in English, and the string extraction never picked it up either. Pass the app id as a translation parameter instead. Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> Signed-off-by: Carl Schwan <carl@carlschwan.eu>
3ecf451 to
c1c32de
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
The app id was interpolated into the string handed to IL10N::t(), so the lookup key differed for every blocked app and matched no entry in any catalogue. The message was therefore always shown in English, and the string extraction never picked it up either.
Pass the app id as a translation parameter instead.