Repository navigation
feat(settings): add a default quota selector for new guest accounts - #1618
Conversation
- add a quota selector to the Guests tab mirroring the Accounts quota field: Default, Unlimited, preset sizes, or a typed custom value with a required unit - the Default option shows the preset-derived value read via IAppConfig::getKeyDetails() and follows the active Quick preset; selecting it removes the override - SettingsController exposes and validates guestQuota; GuestManager already applies guest_quota on creation, so guest behaviour is unchanged Closes #1601 Assisted-by: ClaudeCode:claude-opus-4-8 Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com>
Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
Adds a default quota for new guest accounts, configurable from the Guests tab.
This is the second part of #1602, which was split in two: the allowlist regression fix landed separately as #1616, and this PR carries the quota feature.
Feature
500becomes500 KB / 500 MB / 500 GB); a unit is required so the stored value is unambiguous.IAppConfig::getKeyDetails(). Selecting it removes the override so the preset default applies again, and the label follows the active Quick preset even while an override is set.Backend:
ConfiggainsgetGuestQuota(),hasGuestQuotaOverride(),getGuestQuotaDefault()andsetGuestQuota();SettingsController::getConfig()returnsguestQuota(thedefaultsentinel when no override is stored) andguestQuotaDefault, andsetConfig()accepts and validatesguestQuota.GuestManageralready appliesguest_quotaon guest creation, so guest behaviour is unchanged.Docs
Documents the default guest quota in the README and corrects three links that still pointed to the removed
masterbranch.Closes #1601
Testing
🤖 AI (if applicable)
Assisted-by: ClaudeCode:claude-opus-4-8
Screenshots: