Skip to content

test(playwright): add happy-path e2e suite - #1565

Merged
skjnldsv merged 3 commits into
mainfrom
feat/playwright-happy-path
May 15, 2026
Merged

skjnldsv merged 3 commits into
mainfrom
feat/playwright-happy-path

Conversation

@pringelmann

@pringelmann pringelmann commented May 11, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The guests app has no JS test coverage. A handful of regressions slipped through recent releases and customers had to flag them. This adds the bare minimum to catch that class of breakage before it ships.

Two specs and a .todo. Setup borrows from nextcloud/forms: a per-suite Nextcloud container started by @nextcloud/e2e-test-server, chromium project depending on a setup project that enables the guests app. One small extension over the forms setup: an explicit install-readiness wait (waitOnNextcloud) before tests run, since startNextcloud returns as soon as Apache answers and the first API call could otherwise race the boot.

What's covered

  • Admin Guests settings page loads, the section and one toggle render.
  • Invite Guest dialog opens, the form submits, the OCS endpoint returns 2xx, the dialog closes.

What's not covered (and not yet worth covering): error paths, mobile, RTL, visual regression, a11y audits, quotas, group restrictions, app allowlist. If any of those ever regress, we add a spec for it then.

TODO

  • CI run on first PR push
  • Follow-up issue for convert-guest.spec.ts.todo
  • Follow-up issue for container caching in CI (currently 3-5 min boot per run)

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Screenshots before/after for front-end changes
  • Documentation (manuals or wiki) has been updated or is not required
  • Backports requested where applicable (ex: critical bugfixes)
  • Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
  • Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
@pringelmann pringelmann self-assigned this May 11, 2026
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
@pringelmann
pringelmann marked this pull request as ready for review May 13, 2026 11:30
@pringelmann pringelmann added the 3. to review Waiting for reviews label May 13, 2026
@skjnldsv
skjnldsv merged commit 2943e02 into main May 15, 2026
54 checks passed
@skjnldsv
skjnldsv deleted the feat/playwright-happy-path branch May 15, 2026 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants