Repository navigation
test(playwright): add happy-path e2e suite - #1565
Merged
Merged
Conversation
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
skjnldsv
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The guests app has no JS test coverage. A handful of regressions slipped through recent releases and customers had to flag them. This adds the bare minimum to catch that class of breakage before it ships.
Two specs and a
.todo. Setup borrows fromnextcloud/forms: a per-suite Nextcloud container started by@nextcloud/e2e-test-server, chromium project depending on a setup project that enables the guests app. One small extension over the forms setup: an explicit install-readiness wait (waitOnNextcloud) before tests run, sincestartNextcloudreturns as soon as Apache answers and the first API call could otherwise race the boot.What's covered
What's not covered (and not yet worth covering): error paths, mobile, RTL, visual regression, a11y audits, quotas, group restrictions, app allowlist. If any of those ever regress, we add a spec for it then.
TODO
convert-guest.spec.ts.todoChecklist
3. to review, feature component)stable32)AI (if applicable)