Repository navigation
fix: Fix typing of $mask - #1493
Merged
Merged
Conversation
Make sure it is available in DirMask as it is private in the parent class. Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
requested review from
miaulalala,
nickvergessen and
provokateurin
February 20, 2026 12:50
Comment on lines
+40
to
+41
| * @param array{storage: \OCP\Files\Storage\IStorage, mask: int, path: string, ...} $parameters | ||
| * @psalm-suppress MoreSpecificImplementedParamType |
Member
There was a problem hiding this comment.
Suggested change
| * @param array{storage: \OCP\Files\Storage\IStorage, mask: int, path: string, ...} $parameters | |
| * @psalm-suppress MoreSpecificImplementedParamType | |
| * @param array{storage: \OC\Files\Storage\Storage, mask: int, path: string} $parameters |
I think this is correct?
Member
Author
There was a problem hiding this comment.
Sadly not, psalm will complain that the argument expected are more restrictive than that is written in the base storage wrapper which is just an array.
I don't see a good way around that
provokateurin
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure it is available in DirMask as it is private in the parent class.