Skip to content

fix(UserBackend): do not provision accounts that exist in another backend #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hamza221 merged 1 commit into from
Oct 29, 2026
Merged

fix(UserBackend): do not provision accounts that exist in another backend #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/UserBackend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,12 @@ public function getBackendName(): string {
}

/**
* Creates a user if it does not exist.
* Creates a user if it does not exist in this or any other user backend.
*/
public function createUserIfNotExists(string $uid, bool $firstLoginIfNeeded = true): void {
if (!$this->loadUser($uid)) {
if (!$this->loadUser($uid) && $this->userManager->userExists($uid)) {
$this->logger->warning('Account "' . $uid . '" exists in another user backend, not provisioning it by global scale', ['app' => Application::APP_ID]);
} elseif (!$this->loadUser($uid)) {
$values = [
'uid' => $uid,
];
Expand Down
12 changes: 12 additions & 0 deletions tests/unit/lib/UserBackendTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,18 @@ public function testCreateExistingUserWritesNoAuditLog(): void {
$this->getBackend(true)->createUserIfNotExists('alice', false);
}

public function testCreateUserKnownToOtherBackendInsertsNothing(): void {
$this->userManager->expects($this->once())
->method('userExists')
->with('alice')
->willReturn(true);
$this->db->expects($this->never())->method('getQueryBuilder');
$this->auditLogService->expects($this->never())->method('log');
$this->stopAtHomeSetup();

$this->getBackend(false)->createUserIfNotExists('alice', false);
}

private function prepareGroups(array $currentGroups): void {
$user = $this->createMock(IUser::class);
$user->method('getUID')->willReturn('alice');
Expand Down
Loading