Repository navigation
Conversation
…el binding Importing from the "@nextcloud/vue" barrel pulls the whole component library into the admin entry point, which made "files_pdfviewer-admin.js" 3.8 MiB for a single checkbox. Importing the three components directly keeps only what is used. The switch also bound both "v-model" and "@update:checked". "update:checked" is deprecated in @nextcloud/vue 8 and gone in 9, and "v-model" flipped the switch before the request had been answered, so a failed save left the switch showing a value the server never stored. Binding "model-value" one way and updating it only once the request succeeded keeps the two in sync. Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Member
Author
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1562