Repository navigation
fix: Fix "t()" not found in AdminSettings after porting to Vue3 - #1608
Merged
danxuliu merged 1 commit intoOct 27, 2026
Merged
Conversation
"t())" is no longer added to "Vue.prototype" after porting to Vue3, so it needs to be explicitly imported when needed. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
CarlSchwan
approved these changes
Oct 27, 2026
danxuliu
deleted the
fix-t-not-found-in-adminsettings-after-porting-to-vue3
branch
October 27, 2026 10:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #1568
t()is no longer added toVue.prototypeafter porting to Vue3, so it needs to be explicitly imported when needed.Declaring
t()was also missing in PDFView.vue after porting to Vue3, but it was already added when porting to the new viewer library.Note that in AdminSettings
t()is directly declared as a method instead of using a setup function for consistency with the rest of the file, which still uses the Options API.How to test
Result with this pull request
The settings for the PDF viewer are shown.
Result without this pull request
The settings for the PDF viewer are not shown.