[xhon-pelushi]

Summary

• Add RFC 9554 PRONOUNS as a repeatable text contact property.
• Include it in lightweight CardDAV property fetches and cover serialization with Jest.

Closes #5108

Test plan

• Jest: rfcProps + contact model tests
• npm run build
• UI: add/edit pronouns on a contact and verify round-trip save/reload

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[GVodyanov]

@hamza221 This respects the RFC right? Because code looks good

[EnbyAce]

I think it respects the RFC, based on the changes to the tests/javascript/models/rfcProps.test.js file. The pronouns field should match PRONOUNS:they/them exactly, which does respect RFC 9554.

I don't know how Nextcloud's Contacts app serializes the properties, but RFC9554 also mentions some optional parameters that don't seem to be mentioned anywhere in the commit:

• LANGUAGE
• PREF
• TYPE
• ALTID

[hamza221]

It doesn't look like there's a way to make this interoperable. google contacts doesn't seem to have a pronouns field and apple doesn't save it to vcf and doesn't read it either.
Any ideas about other clients that support this property ?

[EnbyAce]

It doesn't look like there's a way to make this interoperable. google contacts doesn't seem to have a pronouns field and apple doesn't save it to vcf and doesn't read it either. Any ideas about other clients that support this property ?

I don't know of any mobile contacts apps that support the PRONOUNS field, but the mail app version 5.12.4 does show information stored about a contact when writing an email to them.
E.g. when writing an email to hello@example.com and I have a contact which has hello@example.com attached as email and e.g. 19911011 as BDAY property, the mail app would show the contact's birthday to me. (Not actually tested on the BDAY property, but it does definitely work for address etc.)

Would the mail app also show this new PRONOUNS field?

[hamza221]

I think this line should be dropped. we don't want to search on Pronoun

[hamza221]

This icon is already used for gender, @kra-mo , @nimishavijay (as vacation replacement) any recommendation on icon choice ?

[hamza221]

Suggested change

	test('Test pronouns are included in the lightweight property list', () => {
	expect(MinimalContactProperties).toContain('PRONOUNS')
	})

[hamza221]

Suggested change

	import Contact, { MinimalContactProperties } from '../../../src/models/contact'
	import Contact from '../../../src/models/contact'