[cristianscheid]

• Related to: Wrong user count when using teams as team owners circles#2126

Summary

Fixes team population counts to show values consistently across UI.

• This PR is the frontend follow-up of this backend implementation: fix(population): exclude nested circles from population counts circles#2300

Changes

• Always use populationInherited instead of alternating between population (on page load) and member list length (when clicking on a team)
• Update team population values when a member is added/removed or a team is removed
• Parent teams are now also updated correctly when a nested team changes, reflecting the updated population accordingly

Before

before.webm

After

after.webm

Known Issue

Race condition flow

1. Frontend calls Backend LocalController::membersAdd() -> MemberService::addMembers()
2. MemberService::addMembers() triggers FederatedEvent which runs asynchronously
3. Backend returns response immediately (doesn't care if updatePopulation() completed or not)
4. Frontend receives response and calls updateCirclesPopulationCount()
5. Frontend fetches circles from DB (in some cases updatePopulation() did not complete yet)

With this approach, sometimes users might need to reload the page to see correct counts, specifically when adding multiple members at once or when updating a team that's also nested in other teams. This happens because getCircles() is called on the frontend before updatePopulation() in the backend has actually finished executing.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

[codecov]

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/store/circles.js	0.00%	13 Missing ⚠️
.../components/AppNavigation/CircleNavigationItem.vue	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

[hamza221]

rebased to fix CI, Does it need backport ?

[cristianscheid]

rebased to fix CI, Does it need backport ?

Thanks! Yes, I'll request the backports.

[cristianscheid]

/backport to stable8.3

[cristianscheid]

@hamza221 This PR is the frontend counterpart of this one: nextcloud/circles#2300.

On the backend side (nextcloud/circles), I’ve requested backports to stable32 and stable31. Given that, I think we can cancel the backport of this PR to stable7.3 and keep only backport for stable8.3.

Looking at https://apps.nextcloud.com/apps/contacts, if we backport this to stable7.3 (used on nextcloud/server stable30), the Circles backend changes would not be included there, which could lead to frontend errors (e.g. trying to access a key that is not returned).

The reverse is not an issue: the backend implementation is backward-compatible and preserves the existing behavior, so it won’t break the frontend on stable7.3.