Repository navigation
feat(collectives-publish) fix review findings - #2890
Merged
code4candy merged 6 commits intoOct 26, 2026
Merged
code4candy merged 6 commits into
code4candy merged 6 commits into
Conversation
code4candy
marked this pull request as ready for review
October 21, 2026 17:34
code4candy
requested review from
max-nextcloud,
mejo- and
silverkszlo
as code owners
October 21, 2026 17:34
kjoscha
force-pushed
the
feature/collectives-publish
branch
from
October 22, 2026 12:37
ff5585a to
ccd598b
Compare
added 6 commits
October 22, 2026 17:55
Signed-off-by: Melpo <melpomene@posteo.net>
…ault Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Melpo <melpomene@posteo.net> Assisted-by: ClaudeCode:claude-opus-5-5
code4candy
force-pushed
the
publish-feature/address-review-findings
branch
from
October 26, 2026 10:51
d82b555 to
9fc7a41
Compare
2 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Fix review findings in PR Feature: Publish Collective as Static Website:
#2769 (comment)
Acceptance Criteria
IMPORTANT:
publish_enabledis now a boolean value (string before).If you have testet the branch before and run into an error you nee to delete the value and set it again as boolean.
You can use the following commands:
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)