Skip to content

feat(collectives-publish) fix review findings - #2890

Merged
code4candy merged 6 commits into
feature/collectives-publishfrom
publish-feature/address-review-findings
Oct 26, 2026
Merged

code4candy merged 6 commits into
feature/collectives-publishfrom
publish-feature/address-review-findings

Conversation

@code4candy

@code4candy code4candy commented Oct 21, 2026 •

Copy link
Copy Markdown

📝 Summary

Fix review findings in PR Feature: Publish Collective as Static Website:
#2769 (comment)

Acceptance Criteria

  • 1. All points are addressed - either fixed, explained why fix is not necessary or opened a new issue for the topic

IMPORTANT:

publish_enabled is now a boolean value (string before).
If you have testet the branch before and run into an error you nee to delete the value and set it again as boolean.
You can use the following commands:

docker exec -u www-data master-nextcloud-1 php /var/www/html/occ config:app:delete collectives publish_enabled                                                                                                                                                                                                    
docker exec -u www-data master-nextcloud-1 php /var/www/html/occ config:app:set collectives publish_enabled --value true --type boolean                                                                                                                                                                           
docker exec -u www-data master-nextcloud-1 php /var/www/html/occ config:app:get collectives publish_enabled --details   

🚧 TODO

  • ...

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

@code4candy
code4candy requested a review from kjoscha October 21, 2026 17:32
@code4candy
code4candy marked this pull request as ready for review October 21, 2026 17:34
@kjoscha
kjoscha force-pushed the feature/collectives-publish branch from ff5585a to ccd598b Compare October 22, 2026 12:37
Melpo added 6 commits October 22, 2026 17:55
Signed-off-by: Melpo <melpomene@posteo.net>
…ault

Signed-off-by: Melpo <melpomene@posteo.net>
Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Melpo <melpomene@posteo.net>
Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Melpo <melpomene@posteo.net>
Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Melpo <melpomene@posteo.net>
Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Melpo <melpomene@posteo.net>
Assisted-by: ClaudeCode:claude-opus-5-5
@code4candy
code4candy force-pushed the publish-feature/address-review-findings branch from d82b555 to 9fc7a41 Compare October 26, 2026 10:51
@code4candy
code4candy merged commit b011a83 into feature/collectives-publish Oct 26, 2026
53 checks passed
@code4candy
code4candy deleted the publish-feature/address-review-findings branch October 26, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant