Migrate to nextcloud-viewer v2 by mejo- · Pull Request #2854 · nextcloud/collectives

mejo- · 2026-10-13T13:51:36Z

📝 Summary

Resolves: Migrate off the OCA.Viewer global before Nextcloud 36 #2766

Migrates Collectives from the Viewer app's global OCA.Viewer API to the bundled @nextcloud/viewer v2 library, while keeping the old Viewer app working on Nextcloud 33–35.

Viewer migration

Attachments, templates and the version comparison fallback use the v2 library (getViewer().open(), canView(), canCompare(), getViewer().compare()).
registerDefaultHandlers() registers image/audio/video handlers on Nextcloud < 36, where the server doesn't provide them yet.
The viewer's "Open sidebar" button opens the page sidebar on the attachments tab.

Compatibility with Nextcloud 33–35

On these versions, Text and the PDF viewer register their handlers only with the old Viewer app, which the v2 library can't see. Collectives therefore dispatches LoadViewer again where the Viewer app exists, and falls back to OCA.Viewer for files the library can't open (PDF/Markdown attachments, templates) and for version comparison.
Files the library can handle (e.g. images) use the v2 viewer on all versions.

Fixes

Attachments in public shares open in the viewer again (the node was built from relative download URL). Attachment WebDAV URLs are now derived from the page's WebDAV URL, which also works for page shares.

Tests and CI

Migrated the Cypress attachment tests to Playwright and added tests for reopening the page sidebar from the viewer and for opening attachments in collective and page shares.
CI no longer pins Text to a fixed commit; master runs against Text main. Tests adjusted to current Text: session route with file type (Nextcloud 35+), link bubble on hover (click on Nextcloud 33), comparison tab markup, image locator.
Toasts are located by role, as @nextcloud/dialogs 7.5 uses hashed CSS classes.
The Viewer app is installed in CI only for stable33–35.

🏁 Checklist

Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
Sign-off message is added to all commits
Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

🤖 AI (if applicable)

The content of this PR was partly or fully generated using AI tools
The AI-generated content was reviewed, comprehended and tested by a human

skjnldsv · 2026-10-14T15:09:20Z

+export function versionNode(version: VersionInfo): File {
+	const isVersion = version.filename?.startsWith('/versions/')
+	return fileNode({
+		id: version.fileId,
+		source: version.source,
+		mime: version.mime,
+		root: isVersion ? `/versions/${getCurrentUser()?.uid}` : getRootPath(),
+		size: version.size,
+		mtime: new Date(version.mtime),
+		etag: version.etag,
+	})
+}


Looks like someone would benefit from nextcloud/server#65395

nextcloud/server#65397

max-nextcloud

Looks good. Some tests still failing though it seems.

max-nextcloud · 2026-10-14T15:04:23Z

A lot of this seems useful for humans as well. I wonder if we could have all the generic useful stuff in our development docs and then point there from AGENTS.md to avoid duplication.
(As a follow up / separate from this PR)

Signed-off-by: Jonas <jonas@freesources.org>

Fixes: #2766 Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5

Also disable sidebar in templates view as we don't have a useful sidebar there. The files sidebar is not available in Collectives. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5

Nowadays Text doesn't open the link pill on click but only on hover. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5

On public shares, the viewer node was built from the share download link, which is a relative URL. `@nextcloud/files` rejects that, so clicking an attachment fell through to the download link instead of opening the viewer. Build the attachment's WebDAV URL from the page's WebDAV URL instead. Attachments are stored next to the page file, and the page URL already points into the user's files or into the share. This also covers page shares, where the share root is the page folder and not the collective root. Add a Playwright test for collective and page shares, and a `createShare()` helper for page shares to the `CollectivePage` fixture. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5

While the new @nextcloud/viewer v2 also works on older Nextcloud releases, no handlers are registered there by other apps, so we still need to use the older OCA.Viewer way there. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5

mejo- · 2026-10-14T16:38:53Z

The failing Playwright test is unrelated (whiteboard app not migrated to viewer v2 yet).

mejo- self-assigned this Oct 13, 2026

mejo- requested review from max-nextcloud and silverkszlo as code owners October 13, 2026 13:51

mejo- added 3. to review technical debt labels Oct 13, 2026

github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Oct 13, 2026

mejo- moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team Oct 13, 2026

mejo- added 2. developing and removed 3. to review labels Oct 13, 2026

mejo- force-pushed the migrate/viewer_v2 branch 2 times, most recently from bacbfb9 to 62930d3 Compare October 14, 2026 13:14

mejo- requested a review from skjnldsv October 14, 2026 14:41

skjnldsv approved these changes Oct 14, 2026

View reviewed changes

max-nextcloud approved these changes Oct 14, 2026

View reviewed changes

mejo- force-pushed the migrate/viewer_v2 branch 2 times, most recently from 236161d to 7de80b0 Compare October 14, 2026 16:12

mejo- added 14 commits October 14, 2026 18:26

chore: install @nextcloud/viewer library

d48fe4d

Signed-off-by: Jonas <jonas@freesources.org>

chore(viewer): migrate to @nextcloud/viewer v2

2daf4d9

Fixes: #2766 Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5

test(playwright): adjust link bubble tests to new Text behaviour

50ccf38

Nowadays Text doesn't open the link pill on click but only on hover. Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5

test(cypress): fix Text route interceptions with Nextcloud 35+

402152b

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5

chore: add AGENTS.md with instructions for AI agents

dbe0dd5

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5

test(playwright): test opening page sidebar from viewer

1e98760

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5

test: migrate page attachments tests from Cypress to Playwright

2f9dbf2

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5

test: adjust selectors for new toast messages

a333fcd

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5

test(playwright): accept self-signed certificates of local instances

8836545

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5

test(e2e): don't pin and build particular Text Git references

3f3b15e

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5

test(playwright): fix failing tests with latest Text version

60211c0

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5

mejo- added 2 commits October 14, 2026 18:26

test(playwright): fix files app URL in FilesAppSection

a44397f

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5

test(playwright): fix image locator in hasImage()

5b8769b

Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5

mejo- force-pushed the migrate/viewer_v2 branch from 7de80b0 to 5b8769b Compare October 14, 2026 16:26

mejo- merged commit 7ef046d into main Oct 14, 2026
60 of 64 checks passed

mejo- deleted the migrate/viewer_v2 branch October 14, 2026 16:44

mejo- mentioned this pull request Oct 15, 2026

Showing right sidebar when editing a template is not possible #2598

Closed

Navigation Menu

Repository navigation

Migrate to nextcloud-viewer v2 - #2854

Migrate to nextcloud-viewer v2#2854
mejo- merged 16 commits into
mainfrom
migrate/viewer_v2

mejo- commented Oct 13, 2026 •

edited

Loading

Uh oh!

skjnldsv Oct 14, 2026

Uh oh!

max-nextcloud left a comment

Uh oh!

Uh oh!

Uh oh!

max-nextcloud Oct 14, 2026

Uh oh!

mejo- commented Oct 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

mejo- commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Summary

🏁 Checklist

🤖 AI (if applicable)

Uh oh!

skjnldsv Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

max-nextcloud left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

max-nextcloud Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

mejo- commented Oct 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mejo- commented Oct 13, 2026 •

edited

Loading