Skip to content

fix: improve code paths at destroying and cleaning up collectives - #2816

Open
mejo- wants to merge 4 commits into
mainfrom
test/improve_reliability
Open

mejo- wants to merge 4 commits into
mainfrom
test/improve_reliability

Conversation

@mejo-

@mejo- mejo- commented Sep 24, 2026

Copy link
Copy Markdown
Member

📝 Summary

Also contains two changes aiming to make flaky Playwright more robust. Best reviewed commit by commit.

  • test(playwright): upload fixture to random folder
  • test(playwright): close filter menu before typing in page picker
  • fix(versions): delete version entities when purging a collective
  • fix(trash): purge collective before destroying its team

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

🤖 AI (if applicable)

  • The content of this PR was partly generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

@mejo- mejo- self-assigned this Sep 24, 2026
@mejo- mejo- added bug Something isn't working tests labels Sep 24, 2026
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Sep 24, 2026
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team Sep 24, 2026
@mejo-
mejo- force-pushed the test/improve_reliability branch from e12d0b3 to 3151f2a Compare September 24, 2026 16:05
mejo- added 4 commits October 14, 2026 22:28
Should fix errors when the file cannot be overwritten as the Text editor
from a previous session still holds a lock on the file to be written.

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: OpenCode:claude-fable-5.1
Should fix flaky page picker tests.

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: OpenCode:claude-fable-5.1
deleteVersionsFolder() passed the file ID of each version file to
deleteAllVersionsForFile(), which expects the ID of the page file the
versions belong to. The lookup never matched, so the collectives_version
rows of a purged collective were never deleted.

Instead, delete the version entities directly. The version files are
removed along with the collective's versions folder anyway. This also
skips listing each per-file folder.

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: OpenCode:claude-fable-5.1
If purging the collective fails but the team already got destroyed, the
collective no longer can be found in trash (by user). Thus it's safer to
first purge the collective and only destroy the team if this succeeded.

Signed-off-by: Jonas <jonas@freesources.org>
Assisted-by: OpenCode:claude-fable-5.1
@mejo-
mejo- force-pushed the test/improve_reliability branch from 3151f2a to 813b4cd Compare October 14, 2026 20:29

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug Something isn't working tests

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

1 participant