Repository navigation
Fix: fix duplicate entry during indexation (alternative approach) - #2743
Merged
Merged
Conversation
Member
|
@Koc thanks, this looks very promising. I didn't even know about |
Contributor
Author
|
@mejo- sure, give me few days and I will finalize current PR |
Koc
force-pushed
the
bugfix/fix-duplicate-entry-for-alternative-approach
branch
from
September 12, 2026 16:10
658883e to
9e8f94d
Compare
Koc
marked this pull request as ready for review
September 12, 2026 16:27
Koc
requested review from
max-nextcloud,
mejo- and
silverkszlo
as code owners
September 12, 2026 16:27
Koc
force-pushed
the
bugfix/fix-duplicate-entry-for-alternative-approach
branch
from
September 26, 2026 14:44
9e8f94d to
f5a7bbf
Compare
Contributor
Author
|
@mejo- @max-nextcloud mates, what blocks us from merging of this PR? |
2 of 7 tasks
Koc
force-pushed
the
bugfix/fix-duplicate-entry-for-alternative-approach
branch
from
October 12, 2026 07:57
f5a7bbf to
f50973e
Compare
Koc
force-pushed
the
bugfix/fix-duplicate-entry-for-alternative-approach
branch
from
October 31, 2026 12:01
f50973e to
b1820e3
Compare
Use IDBConnection::insertIgnoreConflict() so concurrent inserts into collectives_s_docs, collectives_s_files and collectives_p_versions no longer produce duplicate key errors in the database log. Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com> Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-opus-5-5
mejo-
force-pushed
the
bugfix/fix-duplicate-entry-for-alternative-approach
branch
from
November 2, 2026 13:59
b1820e3 to
d19646d
Compare
mejo-
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
This is alternative approach to fix #1886, #2405. Even after #2451 we observe tons of logs on PostgreSQL side related to duplication. In this PR this logs are gone
🗒️ Next steps
insertIgnoreConflictto the core feat(db): add conflict tolerant inserts to query builder and QBMapper server#64772🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)