Skip to content

feat: Optimize users fetching by moving member management to the Circles - #2685

Open
Koc wants to merge 1 commit into
mainfrom
feature/move-members-management
Open

Koc wants to merge 1 commit into
mainfrom
feature/move-members-management

Conversation

@Koc

@Koc Koc commented Aug 8, 2026 •

Copy link
Copy Markdown
Contributor

📝 Summary

This is a continuation of the work started in #2518 and #2443 to optimize the members list in Collectives.

nextcloud/circles v35 now provides its own members management UI, so Collectives no longer needs to duplicate that functionality. This PR detects that capability and, when it is available, turns the MembersWidget members button into a link that opens the Circles team settings in a new tab. For older Circles versions the existing member management popup is preserved unchanged.

Benefits

  • Smaller member-management surface in Collectives.
  • Faster member fetches because fullDetails=true is skipped when the Circles app already provides the management UI.
  • No behavior change for users on older Circles versions.

🖼️ Screenshots

🏚️ Before 🏡 After
image image

❓ Open question

  • Should we preserve members list popup for members that has no access to the member management (e.g. moderators)?
image

🚧 TODO

  • Manually test more scenarios (WIP)
  • Fix Cypress test for a new behavior

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by a human

@max-nextcloud

Copy link
Copy Markdown
Collaborator

Thanks @Koc

That's definitely matching what the current teams efforts are going for.

@marcoambrosini Is this what you had in mind for managing members from within an app?

Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
@Koc
Koc force-pushed the feature/move-members-management branch from cada522 to 768faef Compare August 8, 2026 20:29

@mejo- mejo- left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understood it, the plan was to provide a shared members management widget that can be injected in other apps, but to keep the possibility to manage members in Collectives without having to leave the app. And that's also what I personally would prefer.

@Koc

Koc commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

@mejo- I can try to do that, but need some more info:

  1. do we have something similar already? where can I inspire from?
  2. how UI should look like? Because for now we have quite different representation of popup in Collectives and page in Circles

@mejo-

mejo- commented Aug 9, 2026

Copy link
Copy Markdown
Member

@Koc thanks, much appreciated. I think the best would be to align with the design team (Cc @marcoambrosini), maybe even in a quick coordination call?

@marcoambrosini

Copy link
Copy Markdown
Member

As far as I understood it, the plan was to provide a shared members management widget that can be injected in other apps, but to keep the possibility to manage members in Collectives without having to leave the app. And that's also what I personally would prefer.

Sorry for the late reply. Yes, this is exactly what I think is best.

@Koc

Koc commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

@marcoambrosini can you please answer to my questions, then?

  • do we have something similar already? where can I inspire from?
  • how UI should look like? Because for now we have quite different representation of popup in Collectives and page in Circles

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants