Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Koc
force-pushed
the
feature/behat-integration-tests
branch
from
November 2, 2026 00:18
a15950d to
beb5faf
Compare
Koc
marked this pull request as ready for review
November 2, 2026 00:18
artonge
reviewed
Nov 3, 2026
artonge
left a comment
Contributor
There was a problem hiding this comment.
What we did currently is to base the integrations tests on PHPUnit here: https://github.com/nextcloud/circles/tree/master/tests/unit/lib/Controller
The reason we did that is mostly because we wanted to avoid Behat and the layer of indirection it brings.
Is there a use case that you want to test which can't be tested with PHPUnit?
Contributor
|
Alternatively, we can also test the API through playwright. Even though it is much heavier than Behat, and even more so than PHPUnit. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a minimal Behat setup so the app's OCS API can be exercised in CI:
Checklist
3. to review, feature component)stable32)AI (if applicable)