Repository navigation
enh(performance): query memberships breadth first to reduce query count - #3072
Merged
grnd-alt merged 1 commit intoOct 22, 2026
Merged
Conversation
grnd-alt
added
enhancement
performance
3. to review
php
CarlSchwan
reviewed
Oct 22, 2026
CarlSchwan
approved these changes
Oct 22, 2026
Signed-off-by: grnd-alt <git@belakkaf.net> Assisted-by: ClaudeCode:claude-sonnet-5-5
grnd-alt
force-pushed
the
enh/reduce-query-count-for-membership-generation
branch
from
October 22, 2026 09:06
b49cfca to
4b273f5
Compare
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable35 |
cristianscheid
approved these changes
Oct 22, 2026
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
generateMembershipfunction was depth first before, which caused the db query count to rise with the amount of circles a user was part in. Now it is breadth first and get's all circles of a level in one query. This makes performance dependent on deepness of the membership path instead of the amount of memberships.Performance test done
I tested on a local instance with a user who has 515 direct memberships
before change: 590 queries produced for the create Circle request
after change: 57 queries produced for the same request
waiting time before: ~2.2 seconds
waiting time after: ~800ms
Checklist
3. to review, feature component)stable32)AI (if applicable)