Skip to content

fix: only show shared resources that are still acessible - #3031

Merged
cristianscheid merged 1 commit into
masterfrom
fix/2408/shared-with-deleted-resource
Oct 14, 2026
Merged

cristianscheid merged 1 commit into
masterfrom
fix/2408/shared-with-deleted-resource

Conversation

@cristianscheid

@cristianscheid cristianscheid commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Previously, when retrieving resources (e.g. files, folder) shared with a team, deleted items or items in trash bin were included
  • This showed the resources as available, like below:
image when clicking on them, user got error file/folder not found, since resource is no longer available
  • This PR filters returned results so it only includes shares with acessible files/folders (not trashed, not deleted)

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@cristianscheid

Copy link
Copy Markdown
Member Author

/backport to stable35

@cristianscheid

Copy link
Copy Markdown
Member Author

/backport to stable34

@cristianscheid

Copy link
Copy Markdown
Member Author

/backport to stable33

Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
@cristianscheid
cristianscheid force-pushed the fix/2408/shared-with-deleted-resource branch from 0654280 to c1d0e22 Compare October 9, 2026 18:33
@CarlSchwan

Copy link
Copy Markdown
Member

Isn't it similar to #3012 ?

@cristianscheid

cristianscheid commented Oct 13, 2026 •

Copy link
Copy Markdown
Member Author

Isn't it similar to #3012 ?

@CarlSchwan it's similar but a bit different. Your PR introduces a method (refreshFileCaches) to update the cached info of given file (path and storage) so it's correctly identified as located in trash or deleted.

This alone is not enough to address the issue this PR solves, since even though files are known to be on trash or deleted, they are not filtered out when retrieving shares via ShareWrapperRequest::getSharesToCircle() or getSharesToCircles().

@kyteinsky kyteinsky left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can confirm, the latest stable34 has this issue but with this PR's changes it's fixed.

@cristianscheid
cristianscheid merged commit fcc8e59 into master Oct 14, 2026
50 checks passed
@cristianscheid
cristianscheid deleted the fix/2408/shared-with-deleted-resource branch October 14, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deleted or trashed folders still appear in teams view

4 participants