Repository navigation
fix: only show shared resources that are still acessible - #3031
Merged
Merged
Conversation
Member
Author
|
/backport to stable35 |
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
cristianscheid
force-pushed
the
fix/2408/shared-with-deleted-resource
branch
from
October 9, 2026 18:33
0654280 to
c1d0e22
Compare
come-nc
approved these changes
Oct 12, 2026
Member
|
Isn't it similar to #3012 ? |
Member
Author
@CarlSchwan it's similar but a bit different. Your PR introduces a method (refreshFileCaches) to update the cached info of given file (path and storage) so it's correctly identified as located in trash or deleted. This alone is not enough to address the issue this PR solves, since even though files are known to be on trash or deleted, they are not filtered out when retrieving shares via ShareWrapperRequest::getSharesToCircle() or getSharesToCircles(). |
kyteinsky
approved these changes
Oct 14, 2026
kyteinsky
left a comment
There was a problem hiding this comment.
can confirm, the latest stable34 has this issue but with this PR's changes it's fixed.
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
3. to review, feature component)stable32)AI (if applicable)