Repository navigation
#2966 fix: reintroduce team-joining and appoval feature - #3018
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
stediefan
force-pushed
the
task/2966-join-open-teams
branch
3 times, most recently
from
October 7, 2026 05:18
7a711dc to
427340d
Compare
stediefan
marked this pull request as ready for review
October 7, 2026 05:24
Contributor
Author
|
/backport to stable35 |
stediefan
enabled auto-merge (squash)
October 7, 2026 15:41
stediefan
force-pushed
the
task/2966-join-open-teams
branch
from
October 13, 2026 12:22
427340d to
e8651da
Compare
Signed-off-by: Stefan Dietrich <stefan.dietrich@dataport.de> Assisted-by: GitHub Copilot:Claude Opus 5.5 Signed-off-by: Stefan Dietrich <stefan.dietrich@dataport.de>
stediefan
force-pushed
the
task/2966-join-open-teams
branch
from
October 14, 2026 09:24
e8651da to
655f819
Compare
artonge
approved these changes
Oct 16, 2026
| try { | ||
| const result = await store.joinTeam(team.id) | ||
| if (result === 'joined') { | ||
| showSuccess(t('circles', 'You have joined the team {circleName}.', { circleName: team.displayName })) |
Contributor
There was a problem hiding this comment.
No need for a toast in case of success. The updated UI should be enough
| await router.push({ name: 'team', params: { teamId: team.id } }) | ||
| } | ||
| } else { | ||
| showSuccess(t('circles', 'Your request to join this team is pending approval')) |
|
The backport to # Switch to the target branch and update it
git checkout stable35
git pull origin stable35
# Create the new backport branch
git checkout -b backport/3018/stable35
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 655f8197
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3018/stable35Error: Failed to check for changes with origin/stable35: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixes #2966 and reintroduces the ability to join teams.
also fixes the approval process.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)