Skip to content

fix: avoid attempting to fetch protected resources when user is not a member - #2673

Merged
cristianscheid merged 1 commit into
masterfrom
fix/noid/visible-circle-avoid-fetch
Jul 24, 2026
Merged

cristianscheid merged 1 commit into
masterfrom
fix/noid/visible-circle-avoid-fetch

Conversation

@cristianscheid

@cristianscheid cristianscheid commented Jul 23, 2026 •

Copy link
Copy Markdown
Member

Summary

This PR replicates nextcloud/contacts#5585 fix here. Since #2561 was not backported, this one should also not need to be backported.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@pringelmann

Copy link
Copy Markdown
Contributor

Will check why CI is failing

@pringelmann pringelmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just needs assets pushed. I have opened a second PR for the failing type check: #2676

@cristianscheid
cristianscheid force-pushed the fix/noid/visible-circle-avoid-fetch branch from 6de7fe8 to fdda369 Compare July 24, 2026 12:25
… member

Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
@cristianscheid
cristianscheid force-pushed the fix/noid/visible-circle-avoid-fetch branch from fdda369 to 0fe2018 Compare July 24, 2026 12:27
@cristianscheid
cristianscheid merged commit 6141fea into master Jul 24, 2026
41 checks passed
@cristianscheid
cristianscheid deleted the fix/noid/visible-circle-avoid-fetch branch July 24, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants