Skip to content

feat: Add filter by role and username - #2659

Merged
susnux merged 2 commits into
masterfrom
feature/add-filters-for-members
Jul 27, 2026
Merged

susnux merged 2 commits into
masterfrom
feature/add-filters-for-members

Conversation

@Koc

@Koc Koc commented Jul 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

This is a follow-up for #2561 inspired by nextcloud/contacts#5330:

  • added filters by role and username
  • added a spinner for members loading instead of showing error "You currently have no access to the member list"
  • reload members list once we've added new members to the Team
  • fix member item actions:
    • fixed an issue with wrongly displayed "Promote to Admin" menu item for current authenticated user in status Moderator
    • show "Leave team" instead of "Remove member" for current authenticated user in list
    • hide "Remove member" for an Team Owner
    • hide "Remove member" if current authenticated user has not greater permissions that member in list
image image

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@codecov

codecov Bot commented Jul 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Koc
Koc force-pushed the feature/add-filters-for-members branch from 1dd3846 to eaa2b5c Compare July 19, 2026 13:45
@Koc
Koc force-pushed the feature/add-filters-for-members branch 2 times, most recently from dc962e1 to 7ba1339 Compare July 19, 2026 14:10
Comment thread src/teams/team-page/services/circles.ts Resolved
Comment thread src/teams/team-page/store/circles.js Resolved
@jancborchardt jancborchardt moved this to 🏗️ At engineering in 🖍 Design team Jul 23, 2026
@Koc
Koc force-pushed the feature/add-filters-for-members branch 6 times, most recently from 553875e to 1bf5f77 Compare July 25, 2026 15:02
@Koc

Koc commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

@pringelmann fixed all code-review comments, please review one more time.

Also I have no idea how to properly build js to satisfy the pipeline. I've executed npm ci && npm run build, committed all changes but step still failing

@pringelmann pringelmann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Koc can you try npm ci && npm run build again, but this time delete your node_modules first?

If that still does not work then I will take a look a little later

@susnux

susnux commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Also I have no idea how to properly build js to satisfy the pipeline. I've executed npm ci && npm run build, committed all changes but step still failing

Are you using Node 24 and NPM 11?

@Koc

Koc commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

@susnux no, I've used node 20 and npm 9 because of unsupported engine. Will try with your suggested versions

image

@susnux

susnux commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Thats just a warning, you need to use the versions specified in the package.json engines field :)

@Koc

Koc commented Jul 27, 2026 •

Copy link
Copy Markdown
Contributor Author
www-data@php-fpm:~/html/apps/circles$ npm -v
11.18.0
www-data@php-fpm:~/html/apps/circles$ node -v
v24.18.0
rm -rf node_modules/ && npm ci && npm run build

didn't help for me

@susnux

susnux commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

didn't help for me

What do you mean with did not help? No changed assets?

Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
@susnux
susnux force-pushed the feature/add-filters-for-members branch from 1bf5f77 to 73b1a0e Compare July 27, 2026 11:40
@Koc

Koc commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

yes, build result is the same what I've pushed in this PR, git status shows no any changes 🤷‍♂️

@susnux

susnux commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

/compile amend

Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command
nextcloud-command force-pushed the feature/add-filters-for-members branch from 73b1a0e to f63226a Compare July 27, 2026 12:19
@susnux
susnux merged commit 725a5ba into master Jul 27, 2026
41 checks passed
@susnux
susnux deleted the feature/add-filters-for-members branch July 27, 2026 13:23
@github-project-automation github-project-automation Bot moved this from 🏗️ At engineering to 🎉 Done in 🖍 Design team Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants