Repository navigation
feat: Add filter by role and username - #2659
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
1dd3846 to
eaa2b5c
Compare
dc962e1 to
7ba1339
Compare
553875e to
1bf5f77
Compare
|
@pringelmann fixed all code-review comments, please review one more time. Also I have no idea how to properly build js to satisfy the pipeline. I've executed |
pringelmann
left a comment
There was a problem hiding this comment.
@Koc can you try npm ci && npm run build again, but this time delete your node_modules first?
If that still does not work then I will take a look a little later
Are you using Node 24 and NPM 11? |
|
@susnux no, I've used node 20 and npm 9 because of
|
|
Thats just a warning, you need to use the versions specified in the |
didn't help for me |
What do you mean with did not help? No changed assets? |
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
1bf5f77 to
73b1a0e
Compare
|
yes, build result is the same what I've pushed in this PR, |
|
/compile amend |
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
73b1a0e to
f63226a
Compare

Summary
This is a follow-up for #2561 inspired by nextcloud/contacts#5330:
Checklist
3. to review, feature component)stable32)AI (if applicable)