Skip to content

Fix(assistant): Use context.fileid instead of context.data.id - #684

Merged
julien-nc merged 1 commit into
nextcloud:mainfrom
IONOS-Productivity:ah/dev/ai-image-gen-type-error
Oct 8, 2026
Merged

julien-nc merged 1 commit into
nextcloud:mainfrom
IONOS-Productivity:ah/dev/ai-image-gen-type-error

Conversation

@seriAlizations

Copy link
Copy Markdown
Contributor

The Folder context passed by addNewFileMenuEntry exposes the folder ID via the .fileid getter, not .data.id, causing a TypeError on submit.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI: Assisted by Claude Sonnet 4.6

The Folder context passed by addNewFileMenuEntry exposes the folder ID
via the .fileid getter, not .data.id, causing a TypeError on submit.

Signed-off-by: Aliza Held <aliza.held@strato.de>
@seriAlizations
seriAlizations force-pushed the ah/dev/ai-image-gen-type-error branch from fc3b2d6 to 69b522f Compare October 8, 2026 13:44
@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f22de455-cee7-4c84-b488-b05cdfdea839
📥 Commits

Reviewing files that changed from the base of the PR and between d00c92f and 69b522f.

📒 Files selected for processing (1)
  • src/components/FilesNewMenu/GenerateImageDialog.vue

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The scheduled image task’s customId now uses context.fileid instead of context.data.id. The empty-prompt check and request success and failure handling are unchanged.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 69b52

The scheduled image task now uses the Folder’s supported ID getter. The checked menu paths provide numeric folder IDs, and no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: using context.fileid instead of context.data.id to fix the assistant submission error.
Description check ✅ Passed The description explains the TypeError and identifies the correct Folder context property, context.fileid. It directly relates to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@julien-nc julien-nc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! This issue comes from a change in@nextcloud/files >= v4.0.0

@julien-nc
julien-nc merged commit 696fb58 into nextcloud:main Oct 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants