Repository navigation
fix: open file previews with the viewer library - #3074
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
susnux
approved these changes
Nov 2, 2026
skjnldsv
enabled auto-merge
November 2, 2026 19:22
OCA.Viewer is gone in Nextcloud 36. Ask the viewer library whether it shows the file, and open it alone rather than with its folder. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
skjnldsv
force-pushed
the
fix/viewer-library
branch
from
November 2, 2026 19:26
ddb8e85 to
7cab374
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Activity opened file previews through
OCA.Viewer, which is gone in Nextcloud 36. It now uses@nextcloud/viewer:canView()decides whether the viewer shows the file, andopen()gets that file alone. Anything the viewer doesn't show follows the preview's link as before.Fixes #2917
Tried on master: a picture's preview in the stream opens in the viewer.
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.