Repository navigation
refactor: Port away from hooks - #2997
Merged
Merged
Conversation
For the moment, we don't gain any performance advantage because we convert the node into a path directly. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
carl/port-file-hooks
branch
from
October 2, 2026 08:50
c4888d3 to
d96f06c
Compare
artonge
approved these changes
Oct 2, 2026
artonge
left a comment
artonge
left a comment
Collaborator
There was a problem hiding this comment.
🤞 I am always a bit nervous when doing node to path conversions, but should be good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the moment, we don't gain any performance advantage because we convert the node into a path directly.
🤖 AI (if applicable)