Skip to content

docs: restore the migration steps, verbose start and name the AppAPI versions - #155

Open
oleksandr-nc wants to merge 2 commits into
mainfrom
docs/readme-review-followup
Open

oleksandr-nc wants to merge 2 commits into
mainfrom
docs/readme-review-followup

Conversation

@oleksandr-nc

Copy link
Copy Markdown
Contributor

Review points on #153 that came in before it was merged: the earlier migration steps read better, the build-from-source example should keep HP_VERBOSE_START for a local setup, and the route verb item should name the AppAPI versions that send the verbs.

Changes

  • The DSP to HaRP migration steps are back as they were before docs: shorten the README #153.
  • The build-from-source example sets HP_VERBOSE_START="1" again.
  • Route item 1 says that AppAPI sends the verbs from Nextcloud 33.0.11, 34.0.6 and 35.0.3.

…versions

Signed-off-by: Oleksandr Piskun <oleksandr2088@icloud.com>
@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5b6c2c2c-b74e-4bec-b226-b7aebb21f9dd
Commits

Reviewing files that changed from the base of the PR and between cdc6d23 and 73bbd1e.

Files selected for processing: 1
  • README.md
Walkthrough

The README retains guidance on HTTP method matching, decoded paths, and URL-only matching in older versions. It updates the Nextcloud 32 DSP migration steps and sets HP_VERBOSE_START=1 in the source-build example.

Priority: Low

Merge Risk: Low · previous review cdc6d

Users may configure routes incorrectly or have difficulty locating the deployment test, but these documentation issues do not affect runtime behavior.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely summarizes the documentation changes: restored migration steps, restored verbose start configuration, and named AppAPI versions.
Description check Passed The description directly matches the changeset and explains each documentation update.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


Review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e4dd56b2-d55d-420b-8ca3-7f629d1d4578
Commits

Reviewing files that changed from the base of the PR and between 09a8222 and cdc6d23.

Files selected for processing: 1
  • README.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Comment thread README.md
Comment thread README.md Outdated
Signed-off-by: Oleksandr Piskun <oleksandr2088@icloud.com>

@kyteinsky kyteinsky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants