Repository navigation
ci: migrate to nextcloud-libraries/parse-package-engines-action - #803
Conversation
skjnldsv
added
3. to review
6b64d68 to
8b62ab4
Compare
It also reads devEngines and is already used by the playwright template and the nextcloud-libraries templates. It has no fallback inputs, and apps are expected to set engines in their package.json, so the fallbacks go. The steps that skip when there is no package.json now check the step outcome instead of the output. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
8b62ab4 to
121bf70
Compare
|
Hmm now it moved from https://github.com/skjnldsv/read-package-engines-version-actions/releases/tag/v4 which just had added node 24 support, to a one year old tag? https://github.com/nextcloud-libraries/parse-package-engines-action/releases/tag/v0.1.0 Was that intentional? Should we push the recent version from skjnldsv repo to our? |
Yes, ours is a completely independent fresh project with nothing shared (it was already written with only ESM and Node24 in mind). |
|
If the lib version is isolated and already using node24 all good. I thought it was an old version of the same lib |
3 participants
Moves the 12 remaining templates to parse-package-engines-action v0.1.0, already used by
playwright.ymland the nextcloud-libraries templates.No more fallbacks, apps are expected to set
engines. The steps that skip without a package.json now check the step outcome, andappstore-build-publishpasses the package.json path instead of the folder.🤖 AI (if applicable)