Repository navigation
Conversation
Styleguidist caches a stylesheet by component name, and the Markdown table and the props table are both called TableRenderer. Whichever rendered first in a session styled both, so after a page with a table in its documentation every props, events and slots table lost its padding, borders and column widths. The Markdown table now renders under its own name with the same styles. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Remko <remko@conduction.nl>
Renders a bordered card with a heading, an optional icon, actions at the end of the heading row, a description, content and a footer, for overviews that show items side by side. The heading is an h3 by default and its level can be set from 2 to 6. With href or to the heading becomes a link that covers the whole card, while the actions, content and footer stay clickable on their own; active highlights the card. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Remko <remko@conduction.nl>
…ve card The content and the footer were lifted above the link that covers the card, so a click on their empty space did nothing. Now only the controls in them are lifted, so the rest follows the link. The link of an active card gets aria-current, and in forced colors the active card gets a thicker border in the system highlight color, as the color and shadow that mark it are replaced there. The clickable area has the rounded corners of the card, and a new target prop opens the link in another tab, with the rel NcButton uses. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Remko <remko@conduction.nl>
The link always got an aria-current key, without a value when the card was not active, which also removed the aria-current="page" RouterLink sets on a link to the current route. The attribute is now only passed for an active card. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Remko <remko@conduction.nl>
remko48
added
3. to review
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9144 +/- ##
==========================================
+ Coverage 59.11% 59.37% +0.25%
==========================================
Files 125 126 +1
Lines 4520 4546 +26
Branches 1347 1362 +15
==========================================
+ Hits 2672 2699 +27
+ Misses 1570 1569 -1
Partials 278 278 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
alignment could probably be improved |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
hreforto, while the actions and controls inside stay clickableactiveto highlight a card and mark it as currenth3by default,heading-levelto change itNote:
CnCardare left out.🖼️ Screenshots
🏁 Checklist
stable8for maintained Vue 2 version or not applicableAI (if applicable)