Repository navigation
Add trigger-rate history storage, API and interactive viewer - #4
Open
jmbenlloch wants to merge 2 commits into
Open
jmbenlloch wants to merge 2 commits into
jmbenlloch wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duck currently retains only per-run rate summaries, so operators cannot inspect how the trigger rate evolved. This adds persistent per-GDC samples, a bounded counter-based history API, and an interactive current-run plot.
Changes
rateSamples, while preservingratessummaries. Add indexed reads, idempotent writes, bounded retries and reset handling; associate samples with their message run.GetRateHistorywith whole-run or explicit time windows and a maximum of 2000 bins. Compute interval rates from counter differences, distribute deltas across bin boundaries and sum GDC contributions. Stream indexed reads in a read-only snapshot, include boundary samples and distinguish incomplete coverage from a measured zero.Validation
The broader existing API race suite is not clean:
TestUpdateRunStatistics_DisabledDevices_Skippedhas a race reproduced on unchanged master. Focused history API race tests pass.Deployment and limits
Apply
database/migrations/20261104_add_rate_samples.sqlto each acquisition schema before deploying the new reader. Deploy the API and frontend together for the viewer. GDC/LDC updates are not required; the simulator profile is optional and defaults to constant rate.Coverage currently uses the GDCs observed in each run, explicitly reported as
observed_run_history, rather than an expected-configuration snapshot. Reader retries use a bounded in-memory queue, not durable buffering. History reads have a ten-second deadline and still scale with the selected raw window; future caching/rollups can preserve the same API contract. The optional demo point limit is unset by default. Generated local demo configuration, database data and browser artifacts are excluded from the PR.