Repository navigation
Upgrade decoder_go to fix database-mode BLR output - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dual-mode BLR data reaches the GDC decoder, but the currently pinned decoder writes zero-filled
/RD/pmtblrarrays and an emptyDataBLRmapping in database mode. Upgradedecoder_gofromb6d9127dba90to60fb7e73e067(v0.0.0-20260709173006-60fb7e73e067), which includes the fix already merged in next-exp/decoder_go#4.The new decoder uses PMT sensor ordering for BLR and consistent waveform/baseline dimensions. This revision also includes upstream sequence-counter and SiPM payload-cleanup fixes, CLI event-count fixes, and regression tests. No Duck application code, database schema or configuration changes are included.
Validation:
go test ./gdcRPC/...passed.go test github.com/next-exp/decoder_go/pkgpassed.Deployed for operator testing in Canfranc on 2026-10-15 from this exact PR head (
922e532), without merging the PR. All seven GDCs were built natively with Go 1.24.4; installed/running checksums match across the fleet and build metadata embeds decoder60fb7e73e067. Native decoder tests and a Blosc/LZ4 bit-shuffle PMT/BLR write/read check passed. Original per-host executables and verified rollback scripts are retained. All GDC/LDC state RPCs returnedINITIALIZED, and run control remained inactive/idle. No acquisition run was started; the operator will validate live dual-mode data.GitHub Actions status: the GDC and backend jobs stop at the existing Docker Hub login step with
Username and password required, before test execution. Their login credentials are unavailable in this PR context. The local GDC/decoder tests, build, and raw-file replay listed above passed.