fix: measure harvest intervals with a monotonic clock - #106
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harvester currently measures elapsed time using the wall clock. If the clock moves backward by an hour between harvests, a five-second interval becomes a 3,605-second wait; moving it forward can trigger an immediate harvest.
Use time.monotonic() for interval accounting, leaving telemetry timestamps unchanged. An explicit None sentinel distinguishes the first interval from a valid zero clock reading. Regression tests simulate both directions of clock adjustment for metric/span-style and event-style batches.
Validation: all four new regression cases fail before the change and pass afterward. All 142 offline tests pass; Ruff lint/format and git diff --check pass. Eight live endpoint tests and network doctests were not validated because outbound API testing was unavailable in this environment.