Repository navigation
fix: normalize empty metric tags before aggregation - #104
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recording a gauge, count, or summary with
tags={}raisesTypeError: unhashable type: 'dict': the empty mapping is left in the metric identity used as a dictionary key.Normalize empty tags to
None, matching omitted tags. This also lets samples recorded with omitted and empty tags aggregate into the same metric. Extend the existing identity and aggregation tests to cover all three metric types.Validation: four cases fail before the fix; all 150 tests pass afterward. Ruff checks and formatting pass. Credential-dependent doctests could not run without a New Relic license key.