Repository navigation
Protect Vulkan frame resources and presentation - #254
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening and resizing the Linux Vulkan editor reproduced premature vkDestroyBuffer/vkDestroyImage operations, and Wayland presentation reproduced VUID-vkQueueSubmit2-semaphore-03868.
Wait for the previous Vulkan submission before frame updates and before viewport resize replaces render resources. This moves the fence wait that already happens during command-buffer start ahead of resource mutation. Update the canonical neutralsoftware/opal revision to the per-swapchain-image presentation semaphore fix in neutralsoftware/opal#3.
Validation: reproduced with the official e89e379 package under Wayland and Khronos validation layers; reviewed resource ordering and ran git diff --check. No local project build was performed. Updated platform CI and runtime checks remain pending.
Refs #238 and #239.