Repository navigation
feat: resolve RTI correspondence references and type request items - #184
netzen-abm wants to merge 25 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f44922357
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ); | ||
| if reference.resource_type == ResourceType::Document { | ||
| if let Some(document) = registries.documents.get_document(&reference.id) { | ||
| if !document.jurisdiction_refs.is_empty() { |
There was a problem hiding this comment.
For a NoticeReply whose registered source document names an authority_ref, this check only compares jurisdiction scopes and never checks that authority against the selected issuing_authority. A notice from a different authority in the same jurisdiction can therefore pass as resolved, leaving the reply preflight pointed at the wrong authority; flag the mismatch or require review.
Useful? React with 👍 / 👎.
| findings.push(review( | ||
| ChecklistFindingCode::MissingSchemeName, | ||
| "rti_details", |
There was a problem hiding this comment.
When a generic RTI request has no scheme-specific context, this branch still emits MissingSchemeName, so evaluate() returns ReviewRequired even though no scheme name applies; the same finding is emitted when rti_details is present but its optional scheme_name is empty. Since this context is documented as optional, only flag a missing name when the request actually concerns a scheme.
Useful? React with 👍 / 👎.
| if source.verification_status != VerificationStatus::Verified { | ||
| push_finding( | ||
| findings, | ||
| review(ChecklistFindingCode::LegalSourceUnverified, field), |
There was a problem hiding this comment.
When a VerifiedRule, OfficialProcedure, or AuthoritativeInterpretation claim cites only a registered LegalSource with source_type == SecondarySource, this branch checks only verification_status and can leave the result StructurallyComplete. A verified secondary source is not authoritative legal support; require an authoritative source or flag the claim for review.
Useful? React with 👍 / 👎.
Purpose
Advance issue #181 from structural checking to registry-backed reference resolution and make the supplied universal RTI template's request list explicit and safer.
Changes
evaluate_with_registriesfor existing Authority, Jurisdiction, Document/DocumentVersion, EvidenceTrust, LegalSource and Procedure registries. It checks resource types, record presence/status, active scope alignment, legal-source verification status and canonical UTC effective interval.Deliberate limits
YYYY-MM-DDTHH:MM:SSZ; alternative forms receive a review finding rather than an inferred comparison.Procedurestores links to sources and steps but does not yet model authority-specific fee amounts/payment modes or filing portal scope as typed fields. This PR intentionally does not add a speculative fee/portal model; that gap remains for a separately specified contract.Repository hygiene
Uses the existing documentation branch; no new active branch. Branch count is exactly nine. PR diff is intended to be limited to
src/administrative_correspondence.rs,src/lib.rsand the corresponding workflow-contract documentation. Archive-first policy remains in force.Verification required
Foundation format/check/test/PostgreSQL/Clippy, Security/Supply Chain, CodeQL, and nine-branch enforcement must complete on the exact PR head. Merge only after required checks are green.