Repository navigation
Match Amp card to the Mac - #812
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 11 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Match the Amp card to the Mac (CodexBar 0.70.0):
with_non_authoritative_pace()otherwise.statusPageURL: nil).Root cause
AmpProvidermetadata used generic labels and a status page URL where upstreamAmpProviderDescriptorhas "Amp Free" / "Balance" and no status page.paceclosure only paces windows withwindowMinutesand a "renews in " reset.Mac reference
Sources/CodexBarCore/Providers/Amp/AmpProviderDescriptor.swift: labels,statusPageURL, pace rule, primary/secondary labels.Sources/CodexBarCore/Providers/Amp/AmpUsageSnapshot.swift: "Monthly allowances" rows (Agent dollars, Orb whole hours, "< 1h").Not changed (after card PR 3)
Tests
mac_parity_tests:metadata_matches_upstream_descriptor,free_tier_has_no_pace,subscription_windows_keep_pace,pace_rule_needs_window_length_and_renewal_text,tier_reports_monthly_allowance_rows,orb_under_one_hour_reads_less_than_one,legacy_subscription_has_no_allowance_rows.Commands
cargo fmt --all: okcargo test --manifest-path rust/Cargo.toml: pass (3809 passed, 0 failed, 1 ignored)cargo clippy --manifest-path rust/Cargo.toml --all-targets -- -D warnings: passcargo test --manifest-path apps/desktop-tauri/src-tauri/Cargo.toml: pass (637 passed)cargo clippy --manifest-path apps/desktop-tauri/src-tauri/Cargo.toml --all-targets -- -D warnings: passpnpm test/pnpm run buildwere not rerun.Proof
W:/mac-parity/win-runs/Amp@followups-main/panel.png(main 44d5de3): "Usage 62% left", "25% in reserve · Lasts until reset", "Usage details", "Status Page".W:/mac-parity/win-runs/Amp@parity-amp/panel.png(this branch f53288c, built withbuild-proof.sh): "Amp Free 62% left", no pace line or disclosure, no Status Page row.W:/mac-parity/scenarios/providers/Amp/card.png.Found by the Mac-parity rig (pack Amp).