Skip to content

Drop the no-op class brush call from DWM chrome #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Finesssee merged 3 commits into from
Oct 11, 2026
Merged

Drop the no-op class brush call from DWM chrome #805

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3216ebc
Drop no-op class brush call from DWM chrome
Finesssee Oct 10, 2026
58daa8b
Keep the dark-mode flag on the tray flyout
Finesssee Oct 10, 2026
ede5ff4
Merge branch 'main' into fix/dwm-light-panel-cleanup
Finesssee Oct 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions apps/desktop-tauri/src-tauri/src/shell/dwm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,15 +88,6 @@ unsafe extern "system" {
) -> i32;
}

#[cfg(windows)]
#[link(name = "gdi32")]
unsafe extern "system" {
fn CreateSolidBrush(color: u32) -> isize;
}

#[cfg(windows)]
static DARK_BRUSH: std::sync::OnceLock<isize> = std::sync::OnceLock::new();

#[cfg(windows)]
const WM_NCCALCSIZE: u32 = 0x0083;
#[cfg(windows)]
Expand Down Expand Up @@ -300,13 +291,6 @@ fn apply_chrome(win: &tauri::WebviewWindow, chrome: Chrome) {
let ok = SetWindowSubclass(hwnd, borderless_subclass_proc, BORDERLESS_SUBCLASS_ID, 0);
tracing::info!("dwm: subclass installed={ok}");

// Set background brush to dark (reuse a single GDI brush)
const GCL_HBRBACKGROUND: i32 = -10;
let brush = *DARK_BRUSH.get_or_init(|| CreateSolidBrush(0x001C1C1E));
if brush != 0 {
SetWindowLongPtrW(hwnd, GCL_HBRBACKGROUND, brush);
}

// Remove WS_CAPTION; only strip WS_THICKFRAME for non-resizable windows
const GWL_STYLE: i32 = -16;
const WS_CAPTION: isize = 0x00C00000;
Expand Down