Skip to content

Isolate bootstrap payload test from real settings #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Finesssee wants to merge 1 commit into from
Closed

Isolate bootstrap payload test from real settings #684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion apps/desktop-tauri/src-tauri/src/commands/bridge.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,7 +721,10 @@ pub struct SettingsSnapshot {

#[tauri::command]
pub fn get_bootstrap_state() -> BootstrapState {
let settings = Settings::load();
bootstrap_state_for(Settings::load())
}

pub(crate) fn bootstrap_state_for(settings: Settings) -> BootstrapState {
BootstrapState {
contract_version: "v1",
providers: provider_catalog_for(&settings),
Expand Down
5 changes: 4 additions & 1 deletion apps/desktop-tauri/src-tauri/src/commands/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1905,7 +1905,10 @@ fn external_url_validator_rejects_non_web_and_control_urls() {

#[test]
fn bootstrap_payload_exposes_every_provider_variant() {
let payload = super::get_bootstrap_state();
// Built from default settings instead of `Settings::load()` so a retired
// provider enabled in the developer's real settings.json cannot change
// the catalog size.
let payload = super::bootstrap_state_for(Settings::default());

let catalog_ids: std::collections::HashSet<String> = payload
.providers
Expand Down