Repository navigation
Make pymeshlab imports lazy in exporter utilities - #3797
Open
AdityaKharmaleGoat7 wants to merge 1 commit into
Open
AdityaKharmaleGoat7 wants to merge 1 commit into
AdityaKharmaleGoat7 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This makes
pymeshlabimports lazy in exporter code so importing non-meshing exporter functionality does not initializepymeshlabunnecessarily.Changes
pymeshlabimport inexporter_utils.pyintoget_mesh_from_filename()pymeshlab.Meshannotation available underTYPE_CHECKINGpymeshlabimport intsdf_utils.pyintoTSDF.export_mesh()pymeshlabunavailableScope
This intentionally does not change the dependency declarations in
pyproject.toml. It is a small first step toward decoupling meshing dependencies and avoids changing installation semantics in the same PR.Related to #3712