Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A ray parallel to an AABB face produces
0/0when its origin lies on that face.intersect_aabbthen returns NaN crop bounds, including throughCameras.generate_rays; even interior parallel rays can have NaN backward gradients from the unused divisions.Handle exact-zero directions using the slab constraint: a parallel ray inside the slab imposes no parameter bound; a parallel ray outside the slab misses the box. Protect the divisor before arithmetic and intersect the remaining finite intervals. Nonzero directions, including very small ones, retain the existing geometry and gradients.
Validation:
git diff --checkpassed.Full
ns-dev-test, GPU/nerfacc execution and rendering/performance benchmarks were not run for this patch.