Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Focus-based camera centering currently inverts a 3x3 normal matrix. Parallel optical axes make that matrix rank-deficient, so a normal forward camera trajectory can abort dataset preparation with
linalg.invinstead of producing a focus estimate.Use
f_prior + A^+ (b - A f_prior)to select the least-squares minimizer nearest the current focus estimate. Full-rank configurations retain the existing solution; parallel cameras preserve the unidentifiable depth along their optical axis. Match the projector identity's device/dtype to the input poses.Validation:
auto_orient_and_center_posesdataset preparation, rigid-world equivariance, a noisy full-rank reference, active-camera fallbacks, and nearly parallel scale consistency.git diff --checkpassed.Full project
ns-dev-test, GPU execution, and reconstruction-quality benchmarks were not run for this patch. Focus-estimator derivatives with respect to pose parameters are not claimed.