Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When COLMAP produces multiple sparse reconstructions,
ns-process-datadefaults tosparse/0. If another reconstruction contains substantially more registered images, this can cause valid frames to be dropped from the generated Nerfstudio dataset.This also occurs with HLoc outputs where additional reconstructions may be stored under nested
models/directories.Fixes #3708.
Solution
When using the default COLMAP model path, automatically select the readable sparse reconstruction with the most registered images.
The selection supports both:
and the HLoc-style layout:
Exact ties are resolved deterministically by model path.
The selected reconstruction is then used consistently for intrinsic refinement, depth export, and transforms generation in both image and video processing pipelines.
Non-default
colmap_model_pathvalues preserve the existing behavior.Testing
Added regression tests covering:
ImagesToNerfstudioDatasetTargeted regression tests pass (
5 passed).The generated dataset was also successfully loaded by the Nerfstudio dataparser and used for a short Nerfacto training smoke test.
git diff --checkpasses.